Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 447 stratosphere qbo #450

Merged
merged 4 commits into from
Jun 28, 2024
Merged

Feature 447 stratosphere qbo #450

merged 4 commits into from
Jun 28, 2024

Conversation

CPKalb
Copy link
Contributor

@CPKalb CPKalb commented Jun 20, 2024

  • Describe testing already performed for these changes:

    Tested the use cases which use these plots to be sure they create plots as expected

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    See instructions in the METplus PR to test these changes, Feature 2557 stratosphere qbo METplus#2621. Documentation for these plots can be found at https://metplotpy.readthedocs.io/en/feature_447_stratosphere_qbo/Users_Guide/stratosphere_plots.html

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
    Yes

  • Do these changes include sufficient testing updates? [Yes or No]
    ??

  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

    No

  • Do these changes introduce new SonarQube findings? [Yes or No]

    No

  • Please complete this pull request review by [Fill in date].

    6/29/2024

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplotpy-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@CPKalb CPKalb linked an issue Jun 20, 2024 that may be closed by this pull request
25 tasks
@CPKalb CPKalb requested a review from j-opatz June 25, 2024 23:27
Copy link
Contributor

@j-opatz j-opatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is tied to the use case PR in the METplus wrappers repo, dtcenter/METplus#2621. For a full review please refer to the METplus wrappers review.

This PR is approved in conjunction with the main PR. Note that there ARE some automated checks for Python vulnerability that failed; I'm not sure what changes (if any) are needed for that to be resolved.

@CPKalb CPKalb merged commit 79df3c7 into develop Jun 28, 2024
5 of 7 checks passed
@CPKalb CPKalb deleted the feature_447_stratosphere_qbo branch June 28, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create new plots for the Stratosphere QBO
2 participants