Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify the color of the no resolution and no skill lines for the reliability diagram #329

Closed
21 tasks
TatianaBurek opened this issue Mar 6, 2023 · 0 comments · Fixed by #393
Closed
21 tasks
Assignees
Labels
METplotpy: Plots reporting: DTC NOAA R2O NOAA Research to Operations DTC Project type: new feature Make it do something new

Comments

@TatianaBurek
Copy link
Collaborator

TatianaBurek commented Mar 6, 2023

Describe the New Feature

no resolution and no skill lines use the assigned static colors. Users would like to select their own colors.
For that we need to add a new color specifying parameters to the YAML config, process them and use for those lines:

  • noskill_line_col
  • reference_line_col

This is the related METviewer issue:
dtcenter/METviewer#465

Acceptance Testing

List input data types and sources.
Describe tests required for new functionality.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 day of work.

Sub-Issues

Consider breaking the new feature down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

2773542

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

New Feature Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@TatianaBurek TatianaBurek added type: new feature Make it do something new alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle METplotpy: Plots labels Mar 6, 2023
@TatianaBurek TatianaBurek added this to the METplotpy 2.1.0-beta2 milestone Mar 6, 2023
@TatianaBurek TatianaBurek self-assigned this Mar 6, 2023
@TatianaBurek TatianaBurek modified the milestones: METplotpy 2.1.0-beta2, METplotpy-2.1.0 Mar 6, 2023
@TatianaBurek TatianaBurek added reporting: DTC NOAA R2O NOAA Research to Operations DTC Project and removed alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Mar 10, 2023
@TatianaBurek TatianaBurek moved this from 🏗 In progress to 👀 In review in METplus-Analysis-6.0.0 Development Oct 17, 2023
@bikegeek bikegeek moved this from 👀 In review to ✅ Done in METplus-Analysis-6.0.0 Development Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
METplotpy: Plots reporting: DTC NOAA R2O NOAA Research to Operations DTC Project type: new feature Make it do something new
Projects
Status: 🏁 Done
Status: 📋 Backlog
3 participants