Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

318: Add test and test data for met_db_load #328

Conversation

John-Sharples
Copy link

  • Add new test data dir and sample data for tests

  • Adds test/utils.py for test helper functions

  • Expands test_met_db_load to count loaded rows from test data

  • Removes test/test_input.py as it didn't test anything

  • Tidy up whitespace, string quotes and reformatting conftest

Pull Request Testing

  • Describe testing already performed for these changes:

    Tests run against local db

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    NA

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]

  • Do these changes include sufficient testing updates? [Yes or No]
    Yes

  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

    Yes, increases coverage to 72%

  • Do these changes introduce new SonarQube findings? [Yes or No]

    If yes, please describe:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METdataio-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

* Add new test data dir and sample data for tests

* Adds test/utils.py for test helper functions

* Expands test_met_db_load to count loaded rows from test data

* Removes test/test_input.py as it didn't test anything

* Tidy up whitespace, string quotes  and reformatting conftest
@bikegeek bikegeek merged commit 61842c0 into dtcenter:develop Sep 6, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants