318: Get existing tests working #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add xml load spec and some test data as conftest fixtures. Use these to create temp files and make tests in test/ use these files. Tests in tests/ still fail.
John-Sharples
requested review from
bikegeek and
georgemccabe
and removed request for
georgemccabe
bikegeek
approved these changes
Jul 26, 2024
|
I will let you do the Squash and merge, and delete the branch. |
|
@bikegeek It appears I'm not authorised to merge this PR |
|
You have 'write' privileges to this repository, I'll see what other things
need to be set for you to perform merges. In the meantime, I've performed
the squash and merge.
Regards,
Minna
…On Sun, Jul 28, 2024 at 4:22 PM John Sharples ***@***.***> wrote:
@bikegeek <https://github.com/bikegeek> It appears I'm not authorised to
merge this PR
—
Reply to this email directly, view it on GitHub
<#319 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4UJHXQJGYEKVWGKOUKJYTZOVVIZAVCNFSM6AAAAABLPT7VPGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJUGY3DSMBQGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
conftest.pyto write some test files to a temp directorytest/pytest test/METdbLoad/test/test_tables.pywrapped in a function and marked to skip.Not in the PR
tests/(plural) still error during setupPull Request Testing
Describe testing already performed for these changes:
Run locally
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Please check these changes run wherever we expect this code to work
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Extensive comments in code.
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [Yes]
If yes, describe the new output and/or changes to the existing output:
tests now use temp files and can be run anywhere.
Do these changes introduce new SonarQube findings? [Yes or No]
If yes, please describe:
Not sure.
Please complete this pull request review by [Fill in date].
No rush.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METdataio-X.Y.Z Development project for official releases