Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed .yaml files to be .yml #303

Closed
wants to merge 1 commit into from

Conversation

mollybsmith-noaa
Copy link
Contributor

Pull request to change all .yaml files in METdataio to use .yml, ensuring uniformity.

Pull Request Testing

  • Describe testing already performed for these changes:

  • Have verified that METdbload still works but I don't really have the capacity to test METreadnc or METreformat

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • If possible, test that METreadnc and METreformat are working as expected.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? -- Change to text of documentation, but no change to documentation structure itself.

  • Do these changes include sufficient testing updates? Yes -- Some test files have extensions changed from .yaml to .yml. If tests pass this should be fine.

  • Will this PR result in changes to the test suite? Yes, see above.

  • Do these changes introduce new SonarQube findings? No

    If yes, please describe:

  • Please complete this pull request review by 5/3/2024.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

Copy link
Contributor

@hankenstein2 hankenstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good and all tests have passed

@jprestop
Copy link
Collaborator

jprestop commented May 1, 2024

@mollybsmith-noaa and @fisherhucar There was some discussion of this topic in Slack on .yml vs. .yaml. Minna and I thought the files were to be renamed .yaml and not .yml. Please see the discussion in the METplus Analysis channel. I'll go tag you both there now.

@jprestop
Copy link
Collaborator

jprestop commented May 1, 2024

Actually, I see that @mollybsmith-noaa added some comments, which I hadn't seen previously. It sounds like we're waiting to hear back from others before deciding on anything.

Copy link
Contributor

@hankenstein2 hankenstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha! Oops, I read this backwards, lets chat in the meeting. I have not merged anything yet.

@jprestop
Copy link
Collaborator

jprestop commented May 1, 2024

@fisherhucar No worries. I won't be at the meeting due to LEAD training, but I'm sure you all have will cover it well. I'll check in on the notes to see what I missed.

@bikegeek bikegeek marked this pull request as draft May 23, 2024 15:11
@bikegeek bikegeek closed this May 23, 2024
@mollybsmith-noaa mollybsmith-noaa deleted the feature_272_standardize_yml branch June 27, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants