loop over statistics only once to avoid data multiplication #330 #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
bikegeek
approved these changes
Oct 13, 2023
jprestop
added a commit
that referenced
this pull request
Feb 2, 2024
* Prepare for next release * add missing end quote to fix package install * reset_index is performed on the float value #322 (#323) * Update release notes (#328) * Update release-notes.rst formatting * Update and rename 2.1.0_wcoss2 to 3.0.0_wcoss2 * loop over statistics only once to avoid data multiplication #330 (#331) * Added sphinx_rtd_theme to extensions * Updated requirements.txt * Added pillow * feature 497 headers (#336) * changing header for continuity * Modified the other headers in the file to be consistent with other repos --------- Co-authored-by: Julie Prestopnik <[email protected]> * Beta2 release (#338) * Next version * Feature 332 di doc (#333) * Add difficulty index documentation * Add more documentation * Add more definition * Fix indent * Add figure * fix indentation * fix equations * Add table * Added remaining tables * fix table issue * Add links * formatting * change link to latest --------- Co-authored-by: Tracy <[email protected]> * Additions to beta2 release (#340) * Next beta * Bugfix 329 negative bcmse (#344) * Issue #329 return 0 if negative BCMSE value is calculated * Issue #329 add test for calculate_bcmse() in the sl1l2_statistics module * Issue #392 added test_sl1l2.py to the list of pytests to run * command line updates * updating yaml file --------- Co-authored-by: Hank Fisher <[email protected]> Co-authored-by: George McCabe <[email protected]> Co-authored-by: John Halley Gotway <[email protected]> Co-authored-by: Tatiana Burek <[email protected]> Co-authored-by: jprestop <[email protected]> Co-authored-by: Tracy Hertneky <[email protected]> Co-authored-by: Tracy <[email protected]> Co-authored-by: bikegeek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Describe testing already performed for these changes:
run test_event_equalize.py and test_event_equalize_against_values.py
tested with METviewer
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
Do these changes include sufficient testing updates? [Yes or No]
Will this PR result in changes to the test suite? [Yes or No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [Fill in date].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes