Issue 239 hss bug for 1 1 (#241)

* fixed calculations of calculate_hss in v1.1 #239 * added v1.1.2
dtcenter · Nov 21, 2022 · 4defd00 · 4defd00
1 parent 983c72b
commit 4defd00
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/docs/Users_Guide/release-notes.rst b/docs/Users_Guide/release-notes.rst
@@ -7,6 +7,12 @@ describes the bugfix, enhancement, or new feature: `METcalcpy GitHub issues. <ht
 Version |version| release notes (|release_date|)
 ------------------------------------------------
 
+Version 1.1.2 release notes (20221118)
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+Bug Fix:
+
+* Fixed Heidke Skill Score Calculation Discrepancy (`#239 <https://github.com/dtcenter/METcalcpy/issues/239>`_)
+
 Version 1.1.1 release notes (20220727)
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 Bug Fix:

diff --git a/docs/version b/docs/version
@@ -1 +1 @@
-__version__="1.1.1"
+__version__="1.1.2"
diff --git a/metcalcpy/util/ctc_statistics.py b/metcalcpy/util/ctc_statistics.py
@@ -387,10 +387,11 @@ def calculate_hss(input_data, columns_names):
         if total == 0:
             return None
         fy_oy = sum_column_data_by_name(input_data, columns_names, 'fy_oy')
-        dbl_c = ((fy_oy + sum_column_data_by_name(input_data, columns_names, 'fy_on')) / total) \
-                * (fy_oy + sum_column_data_by_name(input_data, columns_names, 'fn_oy'))
-        hss = ((fy_oy + sum_column_data_by_name(input_data, columns_names, 'fn_on') - dbl_c)
-               / (total - dbl_c))
+        fy_on = sum_column_data_by_name(input_data, columns_names, 'fy_on')
+        fn_oy = sum_column_data_by_name(input_data, columns_names, 'fn_oy')
+        fn_on = sum_column_data_by_name(input_data, columns_names, 'fn_on')
+        dbl_c = ((fy_oy + fy_on) / total) * (fy_oy + fn_oy) + ((fn_oy + fn_on) / total) * (fy_on + fn_on)
+        hss = ((fy_oy + fn_on - dbl_c) / (total - dbl_c))
         hss = round_half_up(hss, PRECISION)
     except (TypeError, ZeroDivisionError, Warning, ValueError):
         hss = None