Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 2673 sonarqube beta6 vector #2991

Merged
merged 7 commits into from
Oct 14, 2024

Conversation

hsoh-u
Copy link
Collaborator

@hsoh-u hsoh-u commented Oct 10, 2024

Expected Differences

new <data_type> statements were replaced with vector<data_type> .
Less SonarQube findings (code smell category)

  • Reduced 1 bug at dataplane.py

  • Reduced the Code smalls to 18,613 (was 18,909)

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

Unittest and the same outputs

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

N/A

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

  • Do these changes include sufficient testing updates? [No]

  • Will this PR result in changes to the MET test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • [ x Will this PR result in changes to existing METplus Use Cases? [No]

    If yes, create a new Update Truth METplus issue to describe them.

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@JohnHalleyGotway JohnHalleyGotway added this to the MET-12.0.0 milestone Oct 14, 2024
@JohnHalleyGotway JohnHalleyGotway linked an issue Oct 14, 2024 that may be closed by this pull request
21 tasks
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of these changes. Looks great @hsoh-u! Thanks for reducing the code smells by about 1300!

I note that no differences are flagged by the testing workflow and the code changes are as expected. I do note that one bug remains in wchar_argv.cc that we'll need to fix prior to the official release.

@hsoh-u hsoh-u merged commit c5cd28d into develop Oct 14, 2024
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Fix the SonarQube findings for MET version 12.0.0
2 participants