Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix #2979 develop MTD Grid #2981

Merged
merged 9 commits into from
Sep 27, 2024
Merged

Bugfix #2979 develop MTD Grid #2981

merged 9 commits into from
Sep 27, 2024

Commits on Sep 25, 2024

  1. Per #2979, remove nc_grid.h/.cc and replace it with calls to the read… 

    …_netcdf_grid(...) and write_netcdf_proj(...) library utility functions. Note that these changes do compile but I haven't tested whether they actually fix the underlying problem. Also note that nc_utils_local.h/.cc can also likely be replaced with calls to common library functions.
    @JohnHalleyGotway
    JohnHalleyGotway committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    59febc4 View commit details
    Browse the repository at this point in the history

  2. Per #2979, remove references to nc_grid.o from the MTD test code.

    @JohnHalleyGotway
    JohnHalleyGotway committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    719ad4d View commit details
    Browse the repository at this point in the history

  3. Per #2979, insert a newline in unit.py output between the env vars an… 

    …d the command.
    @JohnHalleyGotway
    JohnHalleyGotway committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    1a07b29 View commit details
    Browse the repository at this point in the history

  4. Per #2979, insert a newline in unit.py output between the env vars an… 

    …d the command.
    @JohnHalleyGotway
    JohnHalleyGotway committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    b41757c View commit details
    Browse the repository at this point in the history

  5. Per #2979, the write_netcdf_proj(...) utility function adds the lat a… 

    …nd lon dimensions. Update mtd to NOT define those dimensions prior to calling write_netcdf_proj(...).
    @JohnHalleyGotway
    JohnHalleyGotway committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    dcbb207 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Per #2979, minor changes to is_eq() calls to fix compiler warning mes… 

    …sages
    @JohnHalleyGotway
    JohnHalleyGotway committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    5fbc31a View commit details
    Browse the repository at this point in the history

  2. Per #2979, for the develop branch, also replace nc_utils_local.h/.cc … 

    …with calls to common library code. Also remove commented out code.
    @JohnHalleyGotway
    JohnHalleyGotway committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    67eb4f9 View commit details
    Browse the repository at this point in the history

  3. Per #2979, delete commented out code and make error/warning message f… 

    …ormatting consistent.
    @JohnHalleyGotway
    JohnHalleyGotway committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    c4ddea7 View commit details
    Browse the repository at this point in the history

  4. Fixes for SonarQube

    MET Tools Test Account committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    a0d7c47 View commit details
    Browse the repository at this point in the history