Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Point2Grid to filter quality control strings with config file options #2880

Open
18 of 22 tasks
JohnHalleyGotway opened this issue May 8, 2024 · 2 comments
Open
18 of 22 tasks
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue MET: PreProcessing Tools (Point) priority: blocker Blocker requestor: NOAA/EMC NOAA Environmental Modeling Center required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented May 8, 2024

Describe the Enhancement

While developing a wrapper for the Point2Grid tool via dtcenter/METplus#2540, a short-coming in the Point2Grid configuration file was discovered. Please see this issue comment for details. Put simply, the existing quality_mark_thresh config file option should be replaced by the obs_quality_inc and obs_quality_exc config file options supported for the Point-Stat and Ensemble-Stat tools.

Be sure to update the unit tests to demonstrate these options and update the documentation accordingly.

Time Estimate

1 day

Sub-Issues

Consider breaking the enhancement down into sub-issues.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as the next official version or Backlog of Development Ideas
  • For the next official version, select the MET-X.Y.Z Development project

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: MET-X.Y.Z Development project for development toward the next official release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing requestor: NOAA/EMC NOAA Environmental Modeling Center alert: NEED ACCOUNT KEY Need to assign an account key to this issue MET: PreProcessing Tools (Point) priority: high High Priority labels May 8, 2024
@JohnHalleyGotway JohnHalleyGotway added this to the MET 12.0.0 milestone May 8, 2024
@JohnHalleyGotway JohnHalleyGotway self-assigned this May 8, 2024
@JohnHalleyGotway JohnHalleyGotway changed the title Enhance Point2Grid to filter quality control strings specified in the config file Enhance Point2Grid to filter quality control strings with config file options May 8, 2024
@JohnHalleyGotway JohnHalleyGotway added priority: blocker Blocker and removed priority: high High Priority labels May 15, 2024
@JohnHalleyGotway
Copy link
Collaborator Author

This issue is blocking dtcenter/METplus#2540.

@georgemccabe georgemccabe added the required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone label Jun 4, 2024
JohnHalleyGotway added a commit that referenced this issue Jun 24, 2024
…d obs_quality_inc and obs_quality_exc from the config file.
JohnHalleyGotway added a commit that referenced this issue Sep 18, 2024
@JohnHalleyGotway
Copy link
Collaborator Author

Added logic in point2grid to filter by the obs_qty_inc/exc settings but I get a segfault whenever that code is exercised. Recommend debugging on seneca to see why the MetPointObsData::get_obs_qty(int index) segfaults. Presumably, the obs_qids array it is references is not populated... or something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue MET: PreProcessing Tools (Point) priority: blocker Blocker requestor: NOAA/EMC NOAA Environmental Modeling Center required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Projects
Status: 🏗 In progress
Development

No branches or pull requests

2 participants