Distribute extra rows instead of assigning to last rank #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linearpart<datatype>::getdxdyc() would silently fail to return values for neighbor cells from other ranks, resulting in bad AreaDinf output.
Final rank could have up to numranks extra rows, resulting in load and memory imbalance for large parallel runs. Also remove broken and unused getGridXY() function.
|
Forgot to mention for regression testing that this pull request will change outputs that are dependent on the parallel decomposition, such as the watershed labels, if the number of processes does not evenly divide the number of rows in the raster. Note that these outputs were inconsistent between runs on different process counts already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final rank could have up to numranks extra rows, resulting in load and memory imbalance for large parallel runs.
Also remove broken and unused getGridXY() function.
Based on dinf-dxdyc-fix branch due to conflicting redundant change to calling localToGlobal().