Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support yarn-path config option in yarnrc #348

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

markjm
Copy link

@markjm markjm commented Sep 13, 2021

Fixes #347

const yarnrc = parse(readFileSync(yarnrcPath).toString("UTF8"))
.object as any
if (yarnrc["yarn-path"]) {
yarnrc["yarn-path"] = join(appPath, yarnrc["yarn-path"])
Copy link
Contributor

@NMinhNguyen NMinhNguyen Nov 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if path.resolve would be better than path.join in case the path has something like ../

@orta
Copy link
Collaborator

orta commented Sep 28, 2022

I merged some upstream changes related to the yarnk lockfile which caused some conflicts, and the changes aren't quite simple enough that I'd feel comfortable using the web editor for the conflicts.

I think this is something we should get merged, so if you'd like to rebase, I'm happy to get it in. I think I also agree with @NMinhNguyen on using resolve too (but I'm not 100%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for yarn-path property
4 participants