Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#647] Added Composer normalizer. #652

Merged
merged 1 commit into from
May 14, 2024

Conversation

AlexSkrypnyk
Copy link
Collaborator

Closes #647

@AlexSkrypnyk AlexSkrypnyk self-assigned this May 14, 2024
@AlexSkrypnyk AlexSkrypnyk requested a review from leymannx May 14, 2024 08:55
@AlexSkrypnyk AlexSkrypnyk added the PR: Needs review Pull request needs a review from assigned developers label May 14, 2024
@leymannx
Copy link
Collaborator

@AlexSkrypnyk – Did you already run composer normalize? 🤔

@AlexSkrypnyk AlexSkrypnyk force-pushed the feature/647-11x-add-normalize-composer branch from d1b9c75 to 31a9b9b Compare May 14, 2024 08:59
@AlexSkrypnyk
Copy link
Collaborator Author

AlexSkrypnyk commented May 14, 2024

@leymannx
I did now for both PRs. Sorry.

I was under assumption that this is managed automatically without the need to do composer normalize.

Copy link
Collaborator

@leymannx leymannx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice nice nice! I will create a new issue to add composer normalize --dry-run to the CI

https://github.com/ergebnis/composer-normalize?tab=readme-ov-file#continuous-integration

@AlexSkrypnyk AlexSkrypnyk merged commit b67fbaf into 11.x May 14, 2024
6 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/647-11x-add-normalize-composer branch May 14, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D11 PR: Needs review Pull request needs a review from assigned developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants