Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

full_path is used as namespace in GitLab repository. #49

Closed
wants to merge 1 commit into from

Conversation

odg0318
Copy link

@odg0318 odg0318 commented Nov 25, 2019

I changed from path to full_path as namespace in GitLab repository.

Related to #48

@CLAassistant
Copy link

CLAassistant commented Nov 25, 2019

CLA assistant check
All committers have signed the CLA.

@tboerger
Copy link
Contributor

The namespaced paths will kill Drone as it's not prepared for that. AFAIK @bradrydzewski decided against applying this change as it's quite complex.

@attie
Copy link

attie commented Jan 15, 2020

I have also just bumped in to #48 ... it seems that GitLab support is currently broken if you have a hierarchy deeper than 1.

@tboerger / @bradrydzewski do you know if this fix has been rejected?
If so, do you know if there are any plans to support GitLab properly?

@attie
Copy link

attie commented Jan 15, 2020

Oh, I just found this (i.e: it's considered out of scope):

harness/harness#2009 (comment)

@bradrydzewski
Copy link
Member

bradrydzewski commented Jan 15, 2020

while I appreciate the pull request we have decided we will not support subgroups in Drone. I am going to close this to avoid any potential that we break Drone. We can always revisit and reopen this pull request if something changes in the future.

jstrachan pushed a commit to jstrachan/go-scm that referenced this pull request Dec 22, 2020
feat: Implement CreateStatus, return PR labels in fake.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants