Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat-unacrchive: Added a unarchive conversion step #252

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

vanisrikanithi
Copy link
Contributor

@vanisrikanithi vanisrikanithi commented Nov 25, 2024

Unarchive go-conversion:
Added "Unarchive" support to go-convert specific to jenkins migration.

Unarchive Jenkins Trace:
Vani_Unarchive.json

go run main.go jenkinsjson --downgrade ~/go/Vani_Unarchive.json

Unarchive harness pipeline step:

- step:
    identifier: unarchive4bf5e3
    name: Unarchive
    spec:
      image: plugins/archive
      settings:
        action: extract
        exclude: ''
        format: zip
        glob: '**/*'
        overwrite: 'true'
        source: archive.zip
        target: unarchived_files/zip/

Unarchive Harness Pipeline here

@vanisrikanithi
Copy link
Contributor Author

Hello @Ompragash,

Could you please review the Unarchive PR and provide your comments on this?

Thank you.

@vanisrikanithi
Copy link
Contributor Author

Hello @Ompragash ,

Updated the conversion step from run to plugin using plugis/archive, please review and provide your comments on this.

Click here for harness pipeline.

Thank you.

@Ompragash
Copy link
Member

@vanisrikanithi from the provided pipeline link, I noticed that you tested it only for the zip type. In the spec, you mentioned that the Jenkins unarchive step supports multiple formats like zip, tar, gz, etc.

Can you first confirm all the types supported by the Jenkins unarchive step? Then, test them with plugins/archive in Harness. If any type isn’t supported, we can consider adding it as an enhancement.

@vanisrikanithi
Copy link
Contributor Author

@Ompragash made few changes to the existed plugin Achive to support the tar and gz formats as well tested successfully in the Harness pipeline. Below are the pipelines for different formats.

zip, gz, tar.

Could you please review them and confirm the changes?

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants