Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [CI-14828] : Added Error and Output Secret Handling. #43

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

DevanshMathur19
Copy link

No description provided.

@DevanshMathur19 DevanshMathur19 changed the title Added Error and Output Secret Handling. feat [CI-14828] : Added Error and Output Secret Handling. Oct 22, 2024
@Ompragash Ompragash changed the title feat [CI-14828] : Added Error and Output Secret Handling. feat: [CI-14828] : Added Error and Output Secret Handling. Oct 29, 2024
harness/variables.go Outdated Show resolved Hide resolved
harness/variables.go Outdated Show resolved Hide resolved
harness/variables.go Outdated Show resolved Hide resolved
harness/variables.go Outdated Show resolved Hide resolved
harness/variables.go Outdated Show resolved Hide resolved
harness/variables.go Outdated Show resolved Hide resolved
harness/variables.go Outdated Show resolved Hide resolved
harness/variables.go Outdated Show resolved Hide resolved
harness/variables.go Outdated Show resolved Hide resolved
harness/variables.go Outdated Show resolved Hide resolved
harness/variables.go Outdated Show resolved Hide resolved
harness/variables.go Outdated Show resolved Hide resolved
@Sapa96
Copy link

Sapa96 commented Nov 19, 2024

can we add UTS for these functionalities to ensure their behaviour is proper ?

harness/variables.go Outdated Show resolved Hide resolved
harness/variables.go Outdated Show resolved Hide resolved
harness/variables.go Show resolved Hide resolved
harness/variables.go Show resolved Hide resolved
harness/variables.go Outdated Show resolved Hide resolved
harness/variables.go Outdated Show resolved Hide resolved
Copy link
Member

@Ompragash Ompragash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ompragash
Copy link
Member

Fixed the CI checks via #44

@Ompragash
Copy link
Member

can we add UTS for these functionalities to ensure their behaviour is proper ?

@DevanshMathur19 can you also address the above?

@DevanshMathur19
Copy link
Author

can we add UTS for these functionalities to ensure their behaviour is proper ?

Added.

harness/variables_test.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants