Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge legend and poly.line bugfixes into master #43

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

djvill
Copy link

@djvill djvill commented Sep 12, 2016

Fixed the following bugs with legend and poly.line:

  1. When defining both vowel and group (i.e., vowel!=NULL & group!=NULL), setting plot.tokens=TRUE and plot.means=FALSE, and coloring by group, the wrong colors show up in the legend (regardless of values of var.sty.by or pretty); the right colors show up under the same conditions if coloring by vowel.
  2. There's a similar issue for poly.line=TRUE: if the style variable is vowels and the color variable is something else (i.e., the poly.line connects vowels of the same color), all linetypes will always be the first value of poly.args$lty/exargs$lty or, if both are NULL, solid (lty=1).
  3. Under the same circumstances, the wrong linetypes show up in the legend
  4. When poly.line=TRUE, the color variable is vowels, and the style variable is something else, colored boxes don't show up next to vowels in the legend.

djvill and others added 7 commits September 11, 2016 16:38
Previously, when definining both vowel and group, the wrong colors
showed up in the legend if var.col.by was the same as group (the right
colors showed up if var.col.by was the same as vowel). Fixed bug by
changing definition of byd, such that if var.col.by==group, byd has
length(unique(group)) rows and length(unique(vowel)) columns.
Fixed a bug with poly.line whereby all lines would be the same linetype
if var.col.by had the same value as group. The issue had to do with the
code setting poly.line.sty based on the value of var.sty.by regardless
of the grouping variable. Introduced a bug in the legend where linetypes
display on the wrong lines when var.sty.by!=NULL.
Fixed bug introduced in previous commit; legend correctly shows correct
poly.line linetypes for groups when var.sty.by==vowel and
var.col.by==group.
Fixed a bug in the legend whereby colored boxes for vowels didn't show
up in the legend if plotting poly.lines with var.col.by==vowel and
var.sty.by==group.
add script to test legend generation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants