fix: stream bugs #4240
Merged
fix: stream bugs #4240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR syncs some of the improvements that were introduced in streams in Redis 7.2.3 OSS. 1. verify xsetid against max deleted id in the stream 2. Implement precise memory measurement of streams for "memory usage" command. 3. Always compact nodes in stream listpacks after creating new nodes. Signed-off-by: Roman Gershman <[email protected]>
kostasrim
approved these changes
Dec 3, 2024
| return size; | ||
| } | ||
|
|
||
| size_t MallocUsedStream(stream* s) { |
There was a problem hiding this comment.
I did introduce the exact same function from Valkey and then removed it to replace it with the MemotryTracker 😄
There was a problem hiding this comment.
this way we have a verification mechanism that MemotryTracker captures all the cases - we can run an external script that scans all the stream keys and calls "memory usage" to aggregate the sum
chakaz
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR syncs some of the improvements that were introduced in streams in Redis 7.2.3 OSS.