fix notify deadlock

dragonflydb · Nov 11, 2024 · b1254f6 · b1254f6
1 parent ef6fa2c
commit b1254f6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/server/common.h b/src/server/common.h
@@ -416,7 +416,7 @@ class LocalBlockingCounter {
     DCHECK(mutating_ > 0);
     --mutating_;
     if (mutating_ == 0) {
-      cond_var_.notify_one();
+      cond_var_.notify_all();
     }
   }
 

diff --git a/src/server/db_slice.cc b/src/server/db_slice.cc
@@ -1132,11 +1132,6 @@ DbSlice::PrimeItAndExp DbSlice::ExpireIfNeeded(const Context& cntx, PrimeIterato
                << ", prime table size: " << db->prime.size() << util::fb2::GetStacktrace();
   }
 
-  // Replicate expiry
-  if (auto journal = owner_->journal(); journal) {
-    RecordExpiry(cntx.db_index, key);
-  }
-
   if (expired_keys_events_recording_)
     db->expired_keys_events_.emplace_back(key);
 
@@ -1148,6 +1143,11 @@ DbSlice::PrimeItAndExp DbSlice::ExpireIfNeeded(const Context& cntx, PrimeIterato
   const_cast<DbSlice*>(this)->PerformDeletion(Iterator(it, StringOrView::FromView(key)),
                                               ExpIterator(expire_it, StringOrView::FromView(key)),
                                               db.get());
+  // Replicate expiry
+  if (auto journal = owner_->journal(); journal) {
+    RecordExpiry(cntx.db_index, key);
+  }
+
   ++events_.expired_keys;
 
   return {PrimeIterator{}, ExpireIterator{}};