Touch evidence, children and notes on node merge & add affected_ids to issues#index table cache #1290
Conversation
| if relation == :activities | ||
| source_node.send(relation).update_all(column => target_node.id) | ||
| else | ||
| # update_all doesn't update timestamps so we need to do it manually | ||
| source_node.send(relation).update_all( | ||
| column => target_node.id, | ||
| :updated_at => Time.current | ||
| ) | ||
| end |
There was a problem hiding this comment.
Main changes. The rest is spacing updates
There was a problem hiding this comment.
What about just using update instead of updated_all? update would update the updated_at attribute as part of the method call
| @@ -1,4 +1,4 @@ | |||
| <% cache ['issues-table', @all_columns, issues.map(&:id), @issues.map(&:updated_at).map(&:to_i).sort.last, @tags] do %> | |||
| <% cache ['issues-table', @all_columns, @issues.map(&:affected_ids), issues.map(&:id), @issues.map(&:updated_at).map(&:to_i).sort.last, @tags] do %> | |||
There was a problem hiding this comment.
Should issues be touched when nodes are updated so we don't have to add this to the cache key?
There was a problem hiding this comment.
We already have touch: true in the belongs_to association in the evidence model, and since issues and nodes are connected by evidence, this should suffice in most cases. The reason this is needed is specific to the merge action, which uses update_all so no callbacks are run
There was a problem hiding this comment.
In order to fix this we could call update instead like you mentioned above, but I am concerned about performance implications
Summary
After merging nodes,
:affectedin the cache keys. This leads to broken nodes#show links in the affected columnupdated_atdoes not get updated on node merge since we are usingupdate_all. This leads to broken #edit links (since they point to the old node)This PR adds
:affected_idsto the issues#index table cache key and addsupdated_at: Time.currentto the list of columns to update in merger.rb'smove_descendentsmethodCheck List