Update HTML tag parsing to work with Acunetix 360 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etdsoft
reviewed
Dec 23, 2024
| result.gsub!(/<h[0-9] >(.*?)<\/h[0-9]>/) { "\n\n*#{$1.strip}*\n\n" } | ||
| result.gsub!(/<b>(.*?)<\/b>/) { "*#{$1.strip}*" } | ||
| result.gsub!(/<br\/>/, "\n") | ||
| result.gsub!(/<br\/>|<br \/>/, "\n") |
There was a problem hiding this comment.
can you simplify this with an optional space?
| result.gsub!(/<span.*?>(.*?)<\/span>/m){"#{$1.strip}"} | ||
| result.gsub!(/<span.*?>|<\/span>/, '') #repeating again to deal with nested/empty/incomplete span tags | ||
|
|
||
| result.gsub!(/<a (.*?)href='(.*?)'><i(.*?)><\/i>(.*?)<\/a>/m) { "\"#{$4}\":#{$2}" } |
There was a problem hiding this comment.
Similarly, this one should cover the next one (L19) so we don't need multiple regex's to parse the same tag.
|
|
||
| result.gsub!(/<strong>(.*?)<\/strong>/) { "*#{$1.strip}*" } | ||
| result.gsub!(/<span.*?>(.*?)<\/span>/m){"#{$1.strip}\n"} | ||
| # Cleanup lingering <p></p> |
There was a problem hiding this comment.
@rachkor is this really an issue? We have this and L16 "cleanup" lines, is the code so bad that they include random and
tags all over the place? It seems we're doing something wrong with our parsing.
| result.gsub!(/<pre.*?>(.*?)<\/pre>/) { "\n\nbc. #{$1}\n\n" } | ||
| result.gsub!(/<pre.*?>(.*?)<\/pre>/m){|m| "\n\nbc.. #{$1}\n\np. \n" } | ||
|
|
||
| result.gsub!(/<li.*?>([\s\S]*?)<\/li>/m){"\n* #{$1}"} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The following fields in Acunetix 360 Issues had a ton of HTML tags in the output but our parser wasn't removing them:
This PR resolves these 3 fields plus adds new cleanup for
<em>tags and links with<i>tags.