Remove invalid "Campinas" brazilian city from database #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
|
@dr5hn mind checking in on whether this is the right way to go? thanks |
dr5hn
approved these changes
Jul 7, 2024
|
@skpeter Thanks for the PR! ID structure doesn't bother. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes an invalid entry for "Campinas" in the Santa Catarina ('SC') state of Brazil ('BR').
This entry is not for an actual city, but for a district of the city of São José in SC. In fact, if you look up the coordinates on Google Maps, they point exactly to this district:
https://www.google.com/maps/place/27%C2%B035'40.0%22S+48%C2%B036'25.0%22W/@-27.59444,-48.6095203,17z/
Campinas is actually a city in the state of São Paulo ('SP'), for which there already is a valid entry on the entry right below this one. It's one of the largest cities in Brazil. However, due to both entries in the cities table having the same name, projects using this database may end up matching this city to the incorrect state.
I'm not sure if this deleting this city from the database is the best approach for this, as I'm aware cities in the table have incremental IDs manually assigned to them. Another possible solution would be changing the name to "Campinas (São José)". It still would not match a valid city, but it would keep the ID structure untouched.