add 19 cities and edit 11 city names for Malta #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ryanvelbon
commented
May 29, 2024
•
ryanvelbon
commented
- Some Maltese cities typically include the 'Hal' prefix.
- There are no localities by the name of Saint John and Saint Lucia, even in English these localities are referred to by their Maltese name 'San Gwann' and 'Santa Lucija' respectively.
- San Giljan is commonly known as Saint Julian's by foreigners and English-speakers.
- There are two localities by the name of Santa Lucija: one in mainland Malta and the other in Gozo.
- Vittoriosa is more commonly referred to as Birgu.
Some Maltese cities typically include the 'Hal' prefix. Furthermore, there are no localities by the name of Saint John and Saint Lucia, even in English these localities are referred to by their Maltese name 'San Gwann' and 'Santa Lucija' respectively.
San Giljan is commonly known as Saint Julian's by foreigners and English-speakers. There are two localities by the name of Santa Lucija: one in mainland Malta and the other in Gozo. Vittoriosa is more commonly referred to as Birgu.
dosubot
bot
added
the
size:S
dosubot
bot
added
size:M
ryanvelbon
changed the title
dr5hn
force-pushed
the
master
branch
7 times, most recently
from
414c000
to
42e0f4f
Compare
|
@ryanvelbon Thank you so much for your PR! It's really appreciated. Would like to maintain English language for cities and countries. If you can update your newly added countries to english language that would be great. |
|
Thanks for reviewing. Sorry, I don't understand. The city names provided are the actual names used both by locals (Maltese people) and foreigners. Kindly refer to point 2 in my original post. What exactly should be in English? |
|
Any update? |
dr5hn
approved these changes
Jul 7, 2024
|
@ryanvelbon Understood Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.