Skip to content

Commit

Permalink
use image.tag instead of appversion (#5)
Browse files Browse the repository at this point in the history
* use image.tag instead of appversion

* Update deployment.yaml

* bump version and delete appVersion

* add appVersion and home

* Update Chart.yaml
  • Loading branch information
LeoQuote authored Feb 20, 2021
1 parent 4b03ca6 commit 57f52cc
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 6 deletions.
11 changes: 6 additions & 5 deletions charts/nginx/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
apiVersion: v2
name: nginx
home: https://nginx.org/
description: A Helm chart for Kubernetes

maintainers:
- name: douban
# A chart can be either an 'application' or a 'library' chart.
#
# Application charts are a collection of templates that can be packaged into versioned archives
Expand All @@ -14,8 +16,7 @@ type: application

# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.1.1
version: 0.1.2

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 1.16.0
# This is actually not used.
appVersion: 0.16.0
2 changes: 1 addition & 1 deletion charts/nginx/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ spec:
- name: {{ .Chart.Name }}
securityContext:
{{- toYaml .Values.securityContext | nindent 12 }}
image: "{{ .Values.image.repository }}:{{ .Chart.AppVersion }}"
image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
ports:
- name: http
Expand Down
1 change: 1 addition & 0 deletions charts/nginx/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ replicaCount: 1

image:
repository: nginx
tag: 0.16.0
pullPolicy: IfNotPresent

imagePullSecrets: []
Expand Down

0 comments on commit 57f52cc

Please sign in to comment.