Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser: recover on unfinished isConst patterns #17232

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Parser: recover on unfinished isConst patterns #17232

wants to merge 8 commits into from

Conversation

auduchinok
Copy link
Member

Adds recovery for unfinished IsInstance patterns:

match () with
| :? T
match () with
| :?

@auduchinok auduchinok requested a review from a team as a code owner May 23, 2024 09:44
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 23, 2024 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.400.md

@auduchinok
Copy link
Member Author

This is ready.

@psfinaki
Copy link
Member

This is ready.

I think there are some baselines needing updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psfinaki psfinaki psfinaki left review comments

@T-Gro T-Gro T-Gro approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Status: New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@auduchinok @psfinaki @T-Gro