Use XOR to translate more == and != expressions #34168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the parent expression is not a predicate, translate `x != y` to:
```sql
CAST(x ^ y AS BIT)
```
instead of
```sql
CASE
WHEN x <> y THEN CAST(1 AS bit)
ELSE CAST(0 AS bit)
END
```
Similarly, translate `x == y` to:
```sql
CAST(x ^ y AS BIT) ^ CAST(1 AS bit)
```
instead of
```sql
CASE
WHEN x == y THEN CAST(1 AS bit)
ELSE CAST(0 AS bit)
END
```
Contributes to dotnet#34001.
|
This extends #34124 to all integer types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the parent expression is not a predicate, translate
x != yto:instead of
CASE WHEN x <> y THEN CAST(1 AS bit) ELSE CAST(0 AS bit) ENDSimilarly, translate
x == yto:instead of
CASE WHEN x == y THEN CAST(1 AS bit) ELSE CAST(0 AS bit) ENDContributes to #34001.