-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Debian trixie image #1288
Add Debian trixie image #1288
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
I forgot that we don't have Trixie images in our mirror. |
Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed apt-get upgrade -y, which seems wasteful.
Running an upgrade was intentional. See #1226 for an explanation.
@richlander is there a tracking issue for this on https://github.com/dotnet/core side of things yet? |
There is not. I was going to ping @rbhanda about that. |
I assumed. Why do we have a different practice for this repo than for dotnet/dotnet-docker? Is it that we have a different tradeoff on size vs security/compliance? |
|
Exactly. We don't have the same strictness in these images. It's ok if there's some wasted size in them if it makes our lives easier for maintaining them. |
@liveans -- I tested the latest I see this: root@ad82881d09ec:/# dpkg -i libmsquic_2.4.7_amd64.deb
Selecting previously unselected package libmsquic.
(Reading database ... 5854 files and directories currently installed.)
Preparing to unpack libmsquic_2.4.7_amd64.deb ...
Unpacking libmsquic (2.4.7) ...
dpkg: dependency problems prevent configuration of libmsquic:
libmsquic depends on libxdp1; however:
Package libxdp1 is not installed.
libmsquic depends on libnl-route-3-200; however:
Package libnl-route-3-200 is not installed.
dpkg: error processing package libmsquic (--install):
dependency problems - leaving unconfigured
Errors were encountered while processing:
libmsquic |
Once the libmsquic issues are resolved, I'm going to do some quick size analysis based on the other feedback. |
@richlander Can you also install these packages on x64?
After than that, it should work |
Done. I tested on x64 and Arm64 and that worked. I split the images into their own section so that they are easy to remove when we choose to install the libmsquic package. I also addressed all of the package-manager-related feedback. I am happy to just apply the team standard. If I missed something, do point it out. |
Co-authored-by: Matt Thalman <[email protected]>
It's another Debian release year! My assumption is that we'll start shipping Trixie images in Preview 1, in February. We should look at starting testing in January.
I was unable to make Arm32 work per #1286
I adopted a slightly different pattern, which I think is superior:
apt-get updated
is consumed by all stages.apt-get upgrade -y
, which seems wasteful.