Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify extension method access #42808

Merged
merged 5 commits into from
Oct 2, 2024
Merged

Clarify extension method access #42808

merged 5 commits into from
Oct 2, 2024

Conversation

BillWagner
Copy link
Member

@BillWagner BillWagner commented Oct 2, 2024 •
edited by github-actions bot
Loading

Extension methods must be declared in top-level types. They aren't allowed in nested types.

Internal previews

📄 File 🔗 Preview link
docs/csharp/programming-guide/classes-and-structs/how-to-implement-and-call-a-custom-extension-method.md docs/csharp/programming-guide/classes-and-structs/how-to-implement-and-call-a-custom-extension-method

@BillWagner
Clarify extension method declaration
f0905f5 
Extension methods can only be declared in top-level type. They can't be declared in nested types.
@BillWagner
quick formatting fix
7f4d065
@BillWagner BillWagner requested review from IEvangelist and a team as code owners October 2, 2024 16:53
@dotnetrepoman dotnetrepoman bot added this to the October 2024 milestone Oct 2, 2024
gewarren
gewarren approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@BillWagner BillWagner enabled auto-merge (squash) October 2, 2024 17:04
@BillWagner BillWagner merged commit 3ce2e97 into dotnet:main Oct 2, 2024
8 checks passed
@BillWagner BillWagner deleted the clarify-extension-method-access branch October 2, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewarren gewarren gewarren approved these changes

@IEvangelist IEvangelist Awaiting requested review from IEvangelist IEvangelist is a code owner

Assignees
No one assigned
Labels
dotnet-csharp/svc fundamentals/subsvc
Projects
None yet
Milestone
October 2024
Development

Successfully merging this pull request may close these issues.
2 participants
@BillWagner @gewarren