Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Hide docfx pdf command output options #9710

Merged
merged 6 commits into from
Jul 16, 2024

Conversation

filzrev
Copy link
Contributor

@filzrev filzrev commented Feb 20, 2024

This PR is relating #9696.

It seems docfx pdf command's --output option is not works if manifest.json not exists at specified directory.
This PR add settings to hide option from docfx pdf --help.

Example

docfx pdf --output _site1

FileNotFoundException: Could not find file 'C:\projects\docfx\docs_site2\manifest.json'.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.00%. Comparing base (fe673ec) to head (cbf173c).
Report is 121 commits behind head on main.

❗ Current head cbf173c differs from pull request most recent head 4efe82a. Consider uploading reports for the commit 4efe82a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9710      +/-   ##
==========================================
+ Coverage   74.31%   79.00%   +4.68%     
==========================================
  Files         536      536              
  Lines       23189    23191       +2     
  Branches     4056     4028      -28     
==========================================
+ Hits        17234    18321    +1087     
+ Misses       4853     3746    -1107     
- Partials     1102     1124      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed.

@yufeih yufeih merged commit 09b06ea into dotnet:main Jul 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants