Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make JsonContractResolver inherit CamelCasePropertyNamesContractResolver #3072

Closed
wants to merge 2 commits into from
Closed

Make JsonContractResolver inherit CamelCasePropertyNamesContractResolver #3072

wants to merge 2 commits into from

Conversation

live1206
Copy link
Contributor

Although newton json deserialization is case insensitive, make JsonContractResolver inherit CamelCasePropertyNamesContractResolver to reuse them for serialization setting

…ntractResolver inherit CamelCasePropertyNamesContractResolver to reuse them for serialization setting as well
Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a UT to verify that our custom JsonContractRResolver is case sensitive?

@live1206
Copy link
Contributor Author

Seems like we do not have a way to make Newtonsoft.Json deserialization case sensitive
JamesNK/Newtonsoft.Json#815

@yufeih
Copy link
Contributor

yufeih commented Jul 13, 2018

If it's hard to be case sensitive, let's leave it for now.

@live1206 live1206 closed this Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants