Port "Lock around Http3Stream data frame processing" to main
#56705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follows the same pattern as Http2Stream: https://github.com/dotnet/aspnetcore/blob/main/src/Servers/Kestrel/Core/src/Internal/Http2/Http2Stream.cs#L463 and https://github.com/dotnet/aspnetcore/blob/38fe7dd594bde10cc9c9c3c710947af14d3117b3/src/Servers/Kestrel/Core/src/Internal/Http2/Http2Stream.cs#L490
MackinnonBuck
requested review from
halter73,
BrennanConroy,
JamesNK and
mgravell
as code owners
dotnet-issue-labeler
bot
added
the
area-networking
BrennanConroy
approved these changes
Jul 9, 2024
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Open
3 tasks
|
😆 you don't need to rerun the quarantined runs unless you suspect an issue caused by the PR. |
You're right, I autopiloted and didn't realize it was only the quarantined check failing. I'll merge this 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks some of the changes from #56693 into
main.