Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge from flyperstudio/Comet #283

Closed
wants to merge 1 commit into from

Conversation

flyperstudio
Copy link
Contributor

In this PR, it contains few changes.

Refractory Comet.Tests

  • Separate the Comet.Tests and Comet.Tests.Cases, which cases host all test case.
  • Publish Comet.Tests as a nuget package, users can use it to test their own Comet project
  • Add more test cases.

New way to apply style

Add new way to change the style, user can inherit Button style like this

		public class TestButtonStyle : ButtonStyle
		{
			public TestButtonStyle()
			{
				TextColor = Colors.Red;
				Padding = new Thickness(5);
				TextFont = Font.SystemFontOfSize(10, FontWeight.Regular);
			}
		}

Apply button style like this new Button("Test").Apply<TestButtonStyle>();. User can put style class and UI class into single file, instead of the global style file.

  • Implement apply style logic.
  • Fix some styles mismatch from MAUI.
  • Add test cases for current style classes.

update MAUI version to 7.0.81

@Clancey
Copy link
Collaborator

Clancey commented Apr 25, 2023

Honestly, I think most of this PR isn't needed. Mostly code formatting and project restructuring.
The new Style extensions are totally fine though. Also adding new tests is totally cool. Maybe we do those in a new PR?

@Clancey Clancey closed this Apr 25, 2023
@jessejiang0214
Copy link
Contributor

Hi mate,

I won't check-in unnecessary code into PR.
Some files I need to modify and then format the code at the same time.

I fixed some style not working, like progress, slice, as the MAUI API been changed.
I restructure project, cause I need pack the Test project as a Nuget and I included it into template.

All these changes are necessary, just point out which one you are thinking is no need I will remove it.

Thanks
Jesse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants