-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: variable batching #3198
base: main
Are you sure you want to change the base?
feat: variable batching #3198
Conversation
🦋 Changeset detectedLatest commit: d9c4bf9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🚀 Snapshot Release (
|
Package | Version | Info |
---|---|---|
graphql-yoga-cloud-run-guide |
3.2.0-rc-20240312110020-d9c4bf98 |
npm ↗︎ unpkg ↗︎ |
@graphql-yoga/apollo-link |
3.2.0-rc-20240312110020-d9c4bf98 |
npm ↗︎ unpkg ↗︎ |
@graphql-yoga/urql-exchange |
3.2.0-rc-20240312110020-d9c4bf98 |
npm ↗︎ unpkg ↗︎ |
graphql-yoga |
5.2.0-rc-20240312110020-d9c4bf98 |
npm ↗︎ unpkg ↗︎ |
@graphql-yoga/nestjs |
3.2.0-rc-20240312110020-d9c4bf98 |
npm ↗︎ unpkg ↗︎ |
@graphql-yoga/nestjs-federation |
3.2.0-rc-20240312110020-d9c4bf98 |
npm ↗︎ unpkg ↗︎ |
@graphql-yoga/plugin-apollo-inline-trace |
3.2.0-rc-20240312110020-d9c4bf98 |
npm ↗︎ unpkg ↗︎ |
@graphql-yoga/plugin-apq |
3.2.0-rc-20240312110020-d9c4bf98 |
npm ↗︎ unpkg ↗︎ |
@graphql-yoga/plugin-csrf-prevention |
3.2.0-rc-20240312110020-d9c4bf98 |
npm ↗︎ unpkg ↗︎ |
@graphql-yoga/plugin-defer-stream |
3.2.0-rc-20240312110020-d9c4bf98 |
npm ↗︎ unpkg ↗︎ |
@graphql-yoga/plugin-disable-introspection |
2.2.0-rc-20240312110020-d9c4bf98 |
npm ↗︎ unpkg ↗︎ |
@graphql-yoga/plugin-graphql-sse |
3.2.0-rc-20240312110020-d9c4bf98 |
npm ↗︎ unpkg ↗︎ |
@graphql-yoga/plugin-jwt |
2.2.0-rc-20240312110020-d9c4bf98 |
npm ↗︎ unpkg ↗︎ |
@graphql-yoga/plugin-persisted-operations |
3.2.0-rc-20240312110020-d9c4bf98 |
npm ↗︎ unpkg ↗︎ |
@graphql-yoga/plugin-prometheus |
4.1.0-rc-20240312110020-d9c4bf98 |
npm ↗︎ unpkg ↗︎ |
@graphql-yoga/plugin-response-cache |
3.4.0-rc-20240312110020-d9c4bf98 |
npm ↗︎ unpkg ↗︎ |
@graphql-yoga/plugin-sofa |
3.2.0-rc-20240312110020-d9c4bf98 |
npm ↗︎ unpkg ↗︎ |
@graphql-yoga/render-graphiql |
5.2.0-rc-20240312110020-d9c4bf98 |
npm ↗︎ unpkg ↗︎ |
Apollo Federation Subgraph Compatibility Results
Learn more: |
💻 Website PreviewThe latest changes are available as preview in: https://6863eb74.graphql-yoga.pages.dev |
✅ Benchmark Results
|
params: GraphQLParams | GraphQLParams[], | ||
): GraphQLParams | GraphQLParams[] { | ||
if (Array.isArray(params)) { | ||
return params.map(param => processBatchedParams(param)).flat(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use flatMap
directly instead of chaining map
and flat
?
Lets make this a draft? Or do we want to ship this? We have no real-world use-case.. |
Let's not merge it yet, if so, it should be at least behind a feature flag and marked as experimental. |
I agree with @kamilkisiela . It should be behind a flag at least because it conflicts with graphql-http compliance tests. |
Implementation of Variable Batching;
graphql/composite-schemas-spec#25