refactor(torii): event messages share logic entities #2186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glihm
reviewed
Jul 18, 2024
| @@ -172,7 +170,11 @@ impl Sql { | |||
| let namespaced_name = entity.name(); | |||
| let (model_namespace, model_name) = namespaced_name.split_once('-').unwrap(); | |||
|
|
|||
| let entity_id = format!("{:#x}", poseidon_hash_many(&keys)); | |||
| let entity_id = format!( | |||
| "{}{:#x}", | |||
There was a problem hiding this comment.
Why should we prefix event here? Do we have conflicts possibilities?
As we want them to behave like entities, why not using the exact same way to compute the entity_id?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor the event messages to behave just like entities and use the same tables but with a "event:*" prefix