Add test for SCEP responder #3667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A CI test has been added to set up SCEP responder, build SSCEP client, then run an enrollment test.
c-dorney
approved these changes
Jul 22, 2021
|
@c-dorney Thanks! I'll wait in case there are more comments. |
ladycfu
reviewed
Jul 22, 2021
| -r local.csr \ | ||
| -l local.crt \ | ||
| -E 3des \ | ||
| -S sha256 |
There was a problem hiding this comment.
The last time I played with sscep client on an older platform it didn't support sha256 or 3des and I had to compile one separately. Do you know if this sscep client will support them?
There was a problem hiding this comment.
Yes, it's documented here (look for the -E and -S params):
https://github.com/certnanny/sscep
If those params are not specified, by default it will use des and md5, and the CI will fail. Since the CI passed I suppose those params did work.
There was a problem hiding this comment.
Just FYI there's one unrelated failure in CI caused by a known JSS issue: dogtagpki/jss#781
|
@ckelleyRH Thanks! |
ladycfu
approved these changes
Jul 23, 2021
|
@ladycfu Thanks! I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A CI test has been added to set up SCEP responder,
build SSCEP client, then run an enrollment test.
Docs: