Basic tests for PKCS#10 #556
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Scheel <[email protected]>
Signed-off-by: Alexander Scheel <[email protected]>
cipherboy
added
CI
edewata
approved these changes
May 18, 2020
|
|
||
| CertAndKeyGen ckg = new CertAndKeyGen("RSA", "SHA256withRSA"); | ||
| ckg.generate(4096); | ||
| PKCS10 csr = ckg.getCertRequest(new X500Name("CN=localhost")); |
There was a problem hiding this comment.
Could we add some validations for the CSR?
| public static void main(String[] argv) throws Exception { | ||
| if (argv.length > 2 || argv.length < 1) { | ||
| System.out.println("Usage: TestCertificationRequest <dbdir> [<certfile>]"); | ||
| System.exit(0); |
There was a problem hiding this comment.
I think it should generate a non-zero return code since it fails the test.
| import org.mozilla.jss.pkcs10.*; | ||
| import org.mozilla.jss.pkix.primitive.*; | ||
|
|
||
| public class TestCertificationRequest { |
There was a problem hiding this comment.
No, it requires a CSR to run so I ran it manually. We didn't previously run this test either, but it at least moves it into the correct place in case we want to run it automatically in the future. I think this test should/could be expanded with actual uses of these classes from Dogtag PKI, but we should leave it for a future sprint and/or QE to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic sanity tests for both of JSS's PKCS#10 interfaces.