-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: added key string constants, chainparams and bip32/44 wrappers #158
lib: added key string constants, chainparams and bip32/44 wrappers #158
Conversation
b168658
to
f1b2f87
Compare
address: added depth to dogecoin_hd_generate_key for extended keys chainparams: added isTestnetFromB58Prefix and isMainnetFromB58Prefix wrappers bip32: added wrappers and depth to dogecoin_hd_generate_key for extended keys bip39: moved constant to header bip44: added wrappers and updated to derive_bip44_extended_key key: added wrappers dogecoin: added key string and script constants example: moved constants to header, updated for key string constants, indentation and to derive_bip44_extended_key tool: added wrappers, assert for dogecoin_pubkey_get_hex call and depth to dogecoin_hd_generate_key for extended keys tx: added wrapper vector: added wrappers for serialization/deserialization test: added wrappers to bip32, key, transaction, tool, and vector tests
f1b2f87
to
0601db8
Compare
Tested on x86 windows, linux and aarch64 linux. |
1e0a334
to
e2f8666
Compare
Retested examples on x86 windows, linux and aarch64 linux. |
e2f8666
to
bc849ad
Compare
Retested example with correct result. |
bc849ad
to
85e5ee6
Compare
test: added print of extended key to tool_tests doc: added extended public key derivation
85e5ee6
to
e6320f8
Compare
Retested with update to tool_test. |
one thing i just noticed with regards to the tool test is there are no guards per hardening within
yields an overflow here:
this isn't a blocker per this pr but just wanted to note. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, built and tested on x86_64-pc-linux-gnu.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
big PR but much of that i know is whitespace/tab deletion, lgtm though.
address: added depth to dogecoin_hd_generate_key for extended keys
chainparams: added isTestnetFromB58Prefix and isMainnetFromB58Prefix wrappers
bip32: added wrappers and depth to dogecoin_hd_generate_key for extended keys
bip39: moved constant to header
bip44: added wrappers and updated to derive_bip44_extended_key
key: added wrappers
dogecoin: added key string and script constants
example: moved constants to header, updated for key string constants, indentation and to derive_bip44_extended_key
tool: added wrappers, assert for dogecoin_pubkey_get_hex call and depth to dogecoin_hd_generate_key for extended keys
tx: added wrapper
vector: added wrappers for serialization/deserialization
test: added wrappers to bip32, key, transaction, tool, and vector tests