-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gem Wallet #294
base: main
Are you sure you want to change the base?
Add Gem Wallet #294
Conversation
@qlpqlp thanks for providing a feedback, let me take look into it, will revert back once fixed. |
Much thanks 🙂❤️ |
Hello, I saw the new update and tested, it can send now the 1 Doge, but, if for example I want to pay 1 Doge and only have 1 Doge on the wallet, it does not send 1 Doge but only 0.99808 Doge So, wen paying for example on our MarketPlace https://ShibeShip.com, besides it cant pay the 1 Doge it also cant read the QR code BIP21 (https://github.com/bitcoin/bips/blob/master/bip-0021.mediawiki) to make the payment like the example bellow: My suggestion: wen a user wants to send all amount on the wallet, in my case 1 Doge, show a warning that it will not sent all the amount and actually change the display to the "Full Amount" minus "Network Fees" or a user will not be able to pay in a full an invoice, in our case we are using https://gigawallet.dogecoin.org to create the Dogecoin invoices on https://ShibeShip.com |
Yes, I agree that for BIP21 amount has to be what passed. We will integrate BIP21 within the next couple of weeks for btc/ltc/doge and this would work as you expected (it has to be strict rules on the protocol level). Also, I appreciate that you have tested the app and provided feedback. Let me know if there is anything else we should improve. |
Much thanks for all your efforts :) |
@qlpqlp according to BIP21 there is only I will start with parsing |
I only know one singular universal decentralized currency, Dogecoin :P Probably all Layer 1 cryptocurrencies (AKA Coins, not Tokens), supports BIP21 :) |
Can you review submission again? Both iOS and Android apps should be able to support BIP21 properly and handle your example above. Also, this this comment we have open sourced Gem Wallet |
Screenshots: