Fix/tested haskell judge #543
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorg-vr
reviewed
Oct 4, 2024
| @@ -28,6 +29,10 @@ | |||
|
|
|||
|
|
|||
| class Haskell(Language): | |||
| def __init__(self, config: Optional["GlobalConfig"]): | |||
| super().__init__(config) | |||
| self.clean_types_regex = re.compile(r"\(([^:\s]*)\s*::\s*([A-Z][a-zA-Z0-9]*)\)") | |||
There was a problem hiding this comment.
I think this should be a constant instead of a variable,
So CLEAN_TYPES_REGEX =
Also is this regex completly save? Eg is it possible that it also matches a type expression within a string?
If typing is optional, it would probably be better not to add the type declarations in 'generators.py', instead of adding them there, running the tests with typing and then obfuscating those types to the end user.
jorg-vr
reviewed
Oct 4, 2024
| @@ -48,37 +48,37 @@ def convert_value(value: Value) -> str: | |||
| return f"({convert_arguments(value.data)})" | |||
There was a problem hiding this comment.
This is where I would remove the typing information.
But i am not an expert on TESTed nor haskell so I am not sure it will work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests: