Fix course_id not present bug

[jorg-vr]

This pull request fixes broken code when course is nil. I also restructured the conditionals to improve readability.

[coderabbitai]

Walkthrough

The changes in the SubmissionsController primarily focus on refactoring the create method to improve code clarity and maintainability. The handling of course_id and series_id parameters has been reorganized into conditional statements, enhancing the readability of the logic that checks user membership and the presence of these parameters. The set_submissions method has also been updated to maintain its functionality while ensuring clearer structure and flow in filtering submissions based on various parameters.

Changes

File	Change Summary
app/controllers/submissions_controller.rb	Refactored create method for clarity in handling course_id and series_id parameters; updated set_submissions for improved structure while maintaining functionality.

Possibly related PRs

• Fix legacy 'exercises' path support #5854: The changes in the set_submissions method in both PRs involve modifications to the SubmissionsController, indicating a direct relationship in terms of handling submissions and improving the structure of the code.

Suggested reviewers

• bmesuere

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

app/controllers/submissions_controller.rb (1)

114-122: Improved error handling and data consistency checks

The changes address the "course_id not present" bug and improve data consistency checks. However, there are a few points to consider:

1. The course variable usage in line 121 is ambiguous. It's not clear if this is the same course from line 115 or a different one. Consider using a different variable name or moving the Series.find logic into the first conditional block to clarify the relationship.

2. There's no error handling for Course.find and Series.find. These could raise ActiveRecord::RecordNotFound if the records don't exist. Consider using find_by instead or add error handling to prevent potential crashes.

Consider refactoring the code to address these issues:

if para[:course_id].present?
  course = Course.find_by(id: para[:course_id])
  if course.nil?
    render json: { status: 'failed', errors: 'Course not found' }, status: :not_found
    return
  end
  para.delete(:course_id) if course.subscribed_members.exclude?(current_user)

  if para[:series_id].present?
    series = Series.find_by(id: para[:series_id])
    if series.nil?
      render json: { status: 'failed', errors: 'Series not found' }, status: :not_found
      return
    end
    para.delete(:series_id) if course.series.exclude?(series)
  end
end

This refactoring improves error handling and clarifies the relationship between course and series.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 248fe9d and 9325e48.

📒 Files selected for processing (1)

• app/controllers/submissions_controller.rb (1 hunks)

🧰 Additional context used