-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy sign in method migration for office 365 and smartschool #5791
base: main
Are you sure you want to change the base?
Conversation
Warning Rate limit exceeded@jorg-vr has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 22 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we log if this code path is taken? Maybe we can first log it using events (https://github.com/dodona-edu/dodona/blob/main/app/models/event.rb) or something similar and remove it after a month if it wasn't used.
This pull request removes the migration for the legacy sing in methods for smartschool and office365 which were introduced two years ago.
Smartschool and office 365 accounts that haven't signed in for two years will no longer be able to sign in to their old account.
The database columns
identifier_based_on_username
andidentifier_based_on_email
still exist, should we ever need to fix an existing user and confirm that it was actually an affected user.