Bump the rubocop group across 1 directory with 2 updates

[dependabot]

Bumps the rubocop group with 2 updates in the / directory: rubocop-minitest and rubocop-rails.

Updates rubocop-minitest from 0.35.1 to 0.36.0

Release notes

Sourced from rubocop-minitest's releases.

RuboCop Minitest 0.36.0

Bug fixes

• #317: Fix an error for Minitest/MultipleAssertions when using for-style loops. (@​earlopain)
• #314: Fix an error for Minitest/SkipEnsure when only ensure has a body. (@​earlopain)

Changes

• #314: (Breaking) Raise a useful error when using a Cop in AssertOffense if the Cop's class is not defined. (@​brandoncc)

Changelog

Sourced from rubocop-minitest's changelog.

0.36.0 (2024-08-31)

Bug fixes

• #317: Fix an error for Minitest/MultipleAssertions when using for-style loops. ([@​earlopain][])
• #314: Fix an error for Minitest/SkipEnsure when only ensure has a body. ([@​earlopain][])

Changes

• #314: (Breaking) Raise a useful error when using a Cop in AssertOffense if the Cop's class is not defined. ([@​brandoncc][])

Commits

• 68aed47 Cut 0.36.0
• a7452b7 Update Changelog
• 8a6967d Merge pull request #318 from Earlopain/enable-undefined-config
• a3deb85 Merge pull request #317 from Earlopain/multiple-assertions-error
• 4f75dc5 Merge pull request #316 from Earlopain/error-skip-ensure
• bec9cbb Enable InternalAffairs/UndefinedConfig
• 53d197d Fix an error for Minitest/MultipleAssertions when using for-style loops
• e901adf Fix an error for Minitest/SkipEnsure when only ensure has a body
• 859751a Merge pull request #314 from brandoncc/brandoncc/fail-with-usable-message-if-...
• 2c2add0 Accessing an unregistered cop raises useful error
• Additional commits viewable in compare view

Updates rubocop-rails from 2.26.0 to 2.26.1

Release notes

Sourced from rubocop-rails's releases.

RuboCop Rails 2.26.1

Bug fixes

• #1343: Fix false negatives for Rails/EnumSyntax for non-literal mappings. (@​earlopain)
• #1340: Fix a false positive for Rails/WhereEquals, Rails/WhereNot, and Rails/WhereRange when qualifying the database name. (@​earlopain)

Changes

• #1342: Change Rails/ApplicationRecord to ignore migrations. (@​fatkodima)
• #1350: Change Rails/EnumSyntax to autocorrect underscored options. (@​fatkodima)

Changelog

Sourced from rubocop-rails's changelog.

2.26.1 (2024-09-07)

Bug fixes

• #1343: Fix false negatives for Rails/EnumSyntax for non-literal mappings. ([@​earlopain][])
• #1340: Fix a false positive for Rails/WhereEquals, Rails/WhereNot, and Rails/WhereRange when qualifying the database name. ([@​earlopain][])

Changes

• #1342: Change Rails/ApplicationRecord to ignore migrations. ([@​fatkodima][])
• #1350: Change Rails/EnumSyntax to autocorrect underscored options. ([@​fatkodima][])

Commits

• 6d6fca2 Cut 2.26.1
• 22bc59e Update Changelog
• 16b7f21 Merge pull request #1357 from masato-bkn/add-tests-for-rails-compact-blank
• 027db53 Add missing tests for Rails/CompactBlank when receiver is a hash
• 93f9a89 Merge pull request #1349 from fatkodima/application_record_ignore-migrations
• 9138f7b Merge pull request #1352 from masato-bkn/fix/rails-pluralization-grammar-example
• 5a0a69a Fix example in Rails/PluralizationGrammar
• ff07593 Change Rails/ApplicationRecord to ignore migrations
• ed33413 Merge pull request #1350 from fatkodima/change-enum_syntax-to-autocorrect-und...
• 0a80131 Change Rails/EnumSyntax to autocorrect underscored options
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
• @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
• @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
• @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
• @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

[jorg-vr]

@bmesuere I made some code changes that I would appreciate a double check on:
The return of result at the end of the ensure method was detected as a useless statement.

This seems correct, as the ensure method doesn't by default influence the return value, unless you explicitly mention return. see discussion here: rubocop/rubocop#5949

But reading the code, it does seem like we explicitly want to ensure result is returned.
The only reason I think this used to work is that result happened to be defined on the last line of both the default and the rescue case.

Returning at the end of ensure is still flagged as a code smell (as it silences errors and warnings). I think this is expected behavior in our case and added a comment why I ignored the rubocop warning to make this explicit