-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve UX of evaluation show page #5636
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about this. The current design didn't come out of nowhere and was the result of many iterations taking into account evaluations with multiple columns (in the overview), and limited v-space (on an evaluation itself). I'll first revisit the original iterations (at a later time) before reviewing this.
Bart, I don't remember what were the discussed requested changes for this pr? I do remember discussing that the changes where now much less important due to the 'evaluate' buttons at the top. |
I recall
|
WalkthroughThe recent changes primarily enhance the user experience of the evaluations interface by simplifying the display of feedback statuses, improving button visibility, and refining the layout of feedback entries. Modifications to CSS styles streamline the visual presentation while new helper methods aid in generating clearer feedback titles. Overall, these changes focus on improving usability and clarity for users interacting with evaluations. Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
This pull request replaces the old feedback status icons with the submissions status icons and textual buttons.
This is done because the old icon wasn't clear for new users. The table wasn't readable and it was also unclear that the icons where actually buttons.
Now that the table itself is clearer, I removed the help text.
For reference the old icons:
![image](https://private-user-images.githubusercontent.com/21177904/342393162-e8b6260b-161e-4b8d-bd76-c73e5938c582.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU1OTcyODAsIm5iZiI6MTcyNTU5Njk4MCwicGF0aCI6Ii8yMTE3NzkwNC8zNDIzOTMxNjItZThiNjI2MGItMTYxZS00YjhkLWJkNzYtYzczZTU5MzhjNTgyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTA2VDA0Mjk0MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRmODYzZTYxODYwOTMwNjkyYWNhYzYwMjI0NTEyODVhN2U4MzNjNDVhZjM4N2RiMWViOWYwMmJlYTA4NWZhZDQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.3oiQoKmt6f-2n3w_eo1Ev-9fiLxh6sRoUhfCfp-YW4Q)
Closes #4173