Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

score_item.ts: remove unused functions #4860

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Conversation

freyavs
Copy link
Contributor

@freyavs freyavs commented Aug 1, 2023

This pull request removes unused functions from score_item.ts (so also removing the jQuery)

This is progress on #3590

@freyavs freyavs added the chore Repository/build/dependency maintenance label Aug 1, 2023
@freyavs freyavs self-assigned this Aug 1, 2023
bmesuere
bmesuere previously approved these changes Aug 2, 2023
@bmesuere
Copy link
Member

bmesuere commented Aug 2, 2023

woops, I missed the draft state, ignore my review :)

@bmesuere bmesuere dismissed their stale review August 2, 2023 06:06

still draft

@freyavs freyavs marked this pull request as ready for review August 2, 2023 07:03
@freyavs freyavs requested a review from a team as a code owner August 2, 2023 07:03
@freyavs freyavs requested review from jorg-vr and chvp and removed request for a team August 2, 2023 07:03
@chvp chvp merged commit 835be23 into main Aug 2, 2023
14 of 15 checks passed
@chvp chvp deleted the chore/score-item-jquery-removal branch August 2, 2023 08:15
@chvp chvp temporarily deployed to naos August 2, 2023 08:16 — with GitHub Actions Inactive
@chvp chvp temporarily deployed to production August 2, 2023 08:20 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Repository/build/dependency maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants