Fix memory stats collection during submission running #4807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chvp
requested review from
bmesuere and
niknetniko
and removed request for
a team
chvp
force-pushed
the
fix/memory-collection
branch
from
468a63a
to
9b92b55
Compare
niknetniko
approved these changes
Jul 4, 2023
bmesuere
requested changes
Jul 4, 2023
app/runners/submission_runner.rb
Outdated
| memory = stats['memory_stats']['max_usage'] / (1024.0 * 1024.0) if stats['memory_stats']&.fetch('max_usage', nil) | ||
| before_stats = Time.zone.now | ||
| # Check if container is still running | ||
| if !Rails.env.test? && (Docker::Container.all.select { |c| c.id.starts_with?(container.id) || container.id.starts_with?(container.id) }.any? && container.refresh!.info['State']['Running']) |
There was a problem hiding this comment.
I prefer the old guard style here
There was a problem hiding this comment.
The old guard style is hard to combine with the conditional sleep below.
| memory = [stats['memory_stats']['usage'] / (1024.0 * 1024.0), memory].max if stats['memory_stats']&.fetch('usage', nil) | ||
| end | ||
|
|
||
| # Gathering stats still takes a long time, so if we spent enough time on |
There was a problem hiding this comment.
If it takes a long time, is there a performance impact (since we now do it 5 times more often)?
There was a problem hiding this comment.
Not noticeably on my machine. The runtime is because docker does some sleeps internally to gather the data, IIUC.
bmesuere
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes collection of memory stats during submission running. There were two problems:
memory_stats.max_usageis only available if docker uses cgroups v1 under the hood. We use v2 on all our hosts.