retrieve version from query.

[catalinux]

This is needed when you expecially when you get Dbal Connection from a laravel connection

[kimhemsoe]

Can you explain the usecase a bit more for those of us whom have never touched laravel?

Also i am guessing "version()" does not exist on all platforms and/or agree on the return format, so your proposed solution is a nogo.

[catalinux]

Ok. When the connection is native PHP \PDO, it won't detect the version.

[catalinux]

I could add mysql testing so, I could have

        if ($this->_conn instanceof \PDO && $this->_conn->getAttribute(PDO::ATTR_DRIVER_NAME)==='mysql') {
            try {
                return $this->_conn->query('select version()')->fetchColumn();
            } catch (\PDOException $e) {
                //version query not supported
            }
        }

[Ocramius]

Ok. When the connection is native PHP \PDO, it won't detect the version.

If you provide doctrine with a PDO instance on your own, then it should be up to you to also provide the correct platform to the connection, since you may have done a lot of custom stuff on it anyway.

Can you eventually demonstrate the issue with a failing test case? We don't merge anything that is not coming with corresponding test cases, sorry...

[Ocramius]

I'd rather have a failure here, since it's mysql, and yet something is going horribly wrong. This catch block should go away.

[catalinux]

It makes sense to make tests for my own code. My problem was that when wrapping a PDO Connection of MySql , getDatabasePlatformVersion returns null. Looking more into the code I see there is a requiresQueryForServerVersion mechanism but for PDO this method return false.

I'll dig more into this problem.

[Ocramius]

What you just described is what should be formalized into a test case.

[morozov]

Probably obsolete as of #4115.