Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(doc): fix themeColor in configuration. #2160

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Conversation

Koooooo-7
Copy link
Member

@Koooooo-7 Koooooo-7 commented Aug 3, 2023

Summary

Fix the themeColor config doc changed in #2114 .

> <style>
>   :root {
>     --theme-color: deeppink;
>   }
> </style>

the markdown takes a mistake to treat it as HTML style. See Pink Configuration preview as reproduct.

And, it seems also brings a new feature that we could allow user set theme-color per markdown page . 🚀

What kind of change does this PR introduce?

Docs

For any code change,

  • Related documentation has been updated if needed
  • Related tests have been updated or tests have been added

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge

@vercel
Copy link

vercel bot commented Aug 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview Aug 3, 2023 0:16am

@Koooooo-7 Koooooo-7 marked this pull request as ready for review August 3, 2023 12:20
@Koooooo-7 Koooooo-7 requested review from trusktr and a team August 3, 2023 12:20
@Koooooo-7 Koooooo-7 merged commit 4c2e630 into develop Aug 3, 2023
6 checks passed
@Koooooo-7 Koooooo-7 deleted the fix-themeColor branch August 3, 2023 12:39
--theme-color: deeppink;
}
</style>
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I forgot the code fence. I meant for this to be inside the warning. For example it should be like this:

> **Warning** Deprecated. Use the CSS var `--theme-color` in your `<style>` sheet. Example:
>
> ```html
> <style>
>   :root {
>     --theme-color: deeppink;
>   }
> </style>
> ```

and here's what it looks like inside the quote block:

Warning Deprecated. Use the CSS var --theme-color in your <style> sheet. Example:

<style>
  :root {
    --theme-color: deeppink;
  }
</style>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants