Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: solved navigation to same link error #1922

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

fabiogatti
Copy link

@fabiogatti fabiogatti commented Nov 4, 2022

Summary

Fixed issue where, after clicking one of the anchors on the sidebar, if the user scrolled throughout the page and changed section, it would not allow the navigation to the same id/anchor (Would not re scroll to the same clicked previously)

What kind of change does this PR introduce?

Bugfix

For any code change,

  • Related documentation has been updated if needed
  • Related tests have been updated or tests have been added

Couldn't find any applicable doc or tests, let me know if I missed any.

Does this PR introduce a breaking change? (check one)

  • Yes
  • [ X ] No

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

#1899

Tested in the following browsers:

  • [ X ] Chrome
  • [ X ] Firefox
  • Safari
  • Edge
  • IE

@vercel
Copy link

vercel bot commented Nov 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 22, 2023 at 1:20AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 4, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 506541f:

Sandbox Source
docsify-template Configuration

@Koooooo-7
Copy link
Member

related to #1904

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants