Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where customCriteria was always required #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

speige
Copy link

@speige speige commented Aug 29, 2019

The old logic: _instance.options.customCriteria !== null || _instance.options.customCriteria !== undefined
will ALWAYS return true.

The old logic: _instance.options.customCriteria !== null || _instance.options.customCriteria !== undefined
will *ALWAYS* return true.
@docluv
Copy link
Owner

docluv commented Aug 11, 2020

I will check on this. I have been making major updates to the library the past few weeks.
I am separating the prompt schedule logic from examining if the PWA can be installed. This falls under the latter piece.

@github-staff github-staff deleted a comment Apr 26, 2024
@github-staff github-staff deleted a comment Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants