This repository has been archived by the owner on Jun 11, 2021. It is now read-only.
No option to add volumes #3692
Open
No option to add volumes #3692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Collins Abitekaniza <[email protected]>
Signed-off-by: Collins Abitekaniza <[email protected]>
Signed-off-by: Collins Abitekaniza <[email protected]>
Signed-off-by: Collins Abitekaniza <[email protected]>
|
Adding new container seems to work fine, but mapping existing EXPOSED volumes, seems to create an error? existing volume 😞 |
|
Oops! let me fix this ASAP |
Signed-off-by: Collins Abitekaniza <[email protected]>
|
Fixed 👍 Thank you |
|
Any progress on this? |
|
An admin to review and merge this? Opened since March, really? |
|
Both this PR and #4401 provide the ability to define custom volumes. It would be awesome if one of those implementations were chosen and merged. This is a much needed feature! |
Trackhe
added a commit
to Trackhe/kitematic
that referenced
this pull request
Sep 28, 2019
Merges Pull Request: docker#3462 .. docker#3692 .. docker#4401 .. docker#5306 They are Fix Login. and adding stuff. temporarily simplifying the building. and remove the test.
Trackhe
added a commit
to Trackhe/kitematic
that referenced
this pull request
Sep 28, 2019
Merges Pull Request: docker#3462 .. docker#3692 .. docker#4401 .. docker#5306 They are Fix Login. and adding stuff. temporarily simplifying the building. and remove the test. add building on TC with tag. and pushing release to github.
|
Why has this not been merged yet? @jeanlaurent |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds option for user to add/remove volumes. Fixes #2518